Oliver Joseph Ash

React 18 support

3

Currently `peerDependencies` only allows React 16 and 17.

Disabled/hidden button as menu item breaks arrow keys

2

Reduced test case: https://stackblitz.com/edit/react-ts-41mm9f?file=index.tsx 1. Open the menu button 2. Press down arrow key, "foo" is selected 2. Press down arrow key again Actual: "foo" is still selected Expected: "baz"...

`MenuItem`: custom `onClick` not fired when `tag` is `button` and user presses enter

2

Reduced test case: https://stackblitz.com/edit/react-ts-sbkech?file=index.tsx If you open the menu, focus the `a`, and then press enter, the custom `onClick` handler is fired as seen from the logs. ✅ If you...

React Router Link inside `MenuButton`

3

I am trying to create a menu whereby each item is a link. The reason I want a link rather than a button: - accessibility, e.g. right click -> open...

Fixes this error when passing a (forwarded) `ref` prop into `Button`: ``` Warning: Failed prop type: Invalid prop `forwardedRef` supplied to `AriaMenuButtonButton`. in AriaMenuButtonButton (created by Context.Consumer) ``` 

Distribute files for each type

3

The npm package currently only distributes one large JS file, including all types. It would be great if it distributed a file for each type. This would allow us to...

This library uses [unsafe lifecycle methods](https://reactjs.org/docs/strict-mode.html#identifying-unsafe-lifecycles) which may cause problems when [React's new concurrent mode](https://reactjs.org/docs/concurrent-mode-intro.html) is enabled.

VS Code extension: "Please install Playwright" notification appears when Playwright is already installed

1

### Version 1.43.1 ### Steps to reproduce This issue occurs when using Nix together with [direnv](https://direnv.net/), however I've also shared a reduced test case that reproduces the issue without these...

webpack 5 error when module contains dynamic import: "Automatic publicPath is not supported in this browser"

3

### Current behavior Same as https://github.com/cypress-io/cypress/issues/18435. This issue was marked as fixed but I can still reproduce using the latest version of Cypress. Full reduced test case: https://github.com/OliverJAsh/cypress-webpack-5-public-path-error/tree/upgrade Unfortunately I...

Incremental builds

1

It is now possible to do incremental builds, i.e. https://github.com/jackfranklin/jspm-dev-builder: ``` js const builder = new jspm.Builder(); function build(changedModuleId) { builder.invalidate(changedModuleId); return builder.build('main', 'out'); } build(); // and again, but...