Oliver Joseph Ash

Results 272 issues of Oliver Joseph Ash

## 🐛 Bug report ### Current Behavior It seems this overload is never reached/used: ```ts export function fromPredicate(predicate: Predicate): (a: A) => Option ``` Example: ```ts O.fromPredicate((s: string) => true)...

```ts declare const xs: Array; pipe( xs, A.reject((value) => { value // ^? return true; }), ); ``` The type of `value` is `unknown` but it should be `string`. I...

bug

This fixes the following type error: ```ts import * as H from 'hyper-ts'; import * as HRM from 'hyper-ts/ReaderMiddleware'; import { pipe } from 'shared/facades/function'; type Deps = {}; declare...

Copying suggestion from https://github.com/palantir/tslint-react/issues/116: > We had a case in our code where a semicolon was accidentally used at the end of a line of a tsx statement. Since this...

question
new rule

### What version of React, ReactDOM/React Native, Redux, and React Redux are you using? - React: 18.2.0 (latest at time of writing) - Redux: 4.2.1 (latest at time of writing)...

performance

**Is your feature request related to a problem? Please describe.** I would like to be able to customise the log command used to generate the log in the commits panel...

enhancement

## Are you reporting a bug? https://stackblitz.com/edit/oliverjash-react-autosuggest-clear-and-focus-qi2jdy?file=src%2FApp.js On a mobile/touch device, select a suggestion. **Observed behaviour:** Runtime exception: `TypeError: Cannot read properties of undefined (reading 'languages')`. It seems that `getSectionSuggestions`...

Given: ```ts unsplash.photos.get({ photoId: 'foo/bar' }); ``` Expected: request to `/photos/foo%2Fbar` Actual: request to `/photos/foo/bar` Note: some usages of `getPathname` rely on this behaviour: https://github.com/unsplash/unsplash-web/blob/330bb40640c3e1d3600ecc5a1b15a244013f0c5a/app/services/api/Photo/index.ts#L36C1-L37

Now that browsers have good support for [`inert`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/inert), could we consider replacing the custom focus trap logic with this? Alternatively, we could [use the `dialog` element](https://github.com/reactjs/react-modal/issues/212) so we get this...

discussion
feature
combining libraries
dependencies
browser api
easy
good first issue
accessibility