Oliver Joseph Ash

Results 334 comments of Oliver Joseph Ash

I'm seeing a 2 KB (gzip) increase on my minified webpack bundle—so that's after all comments are removed. I think the new `StatusCodes` enum means we can no longer benefit...

@prettymuchbryce WDYT to this idea? I can send a PR if you like the sound of it. https://github.com/prettymuchbryce/http-status-codes/issues/55#issuecomment-679326893

@prettymuchbryce I had a quick look but it looks like those files are generated and I'm not too familiar with `ts-morph`. In any case I can show you what the...

@prettymuchbryce Hey, do you have any thoughts on the above? This issue is stopping us from upgrading. I would love to help get it fixed 😄

> My bigger concern is that it seems to have made the file size issue even worse according to bundlephobia. Any ideas why that might be? Probably because of [this...

Thanks, unfortunately this is still an issue. We need to update these as well: - https://github.com/mock-server/mockserver-node/blob/6a3200b09928aaf86853a8b63cf9346a2dfeda35/downloadJar.js#L28 - https://github.com/mock-server/mockserver-node/blob/6a3200b09928aaf86853a8b63cf9346a2dfeda35/downloadJar.js#L38

Linking to previous discussions for my own future reference: - https://github.com/unsplash/unsplash-web/pull/6935/files/e1c1355bc39274f37433e73fdd67c65c6e7dd172#r702927554 - https://github.com/unsplash/unsplash-web/pull/6992#discussion_r714725718 - https://github.com/unsplash/unsplash-web/pull/7323#discussion_r760637234 --- If `Eq`s were automatically derived then I guess this wouldn't be an issue. But...

[Here's one idea to solve this](https://github.com/unsplash/sum-types/issues/35#:~:text=Alternatively%2C%20seeing%20as%20toEqual%20gives%20us%20diffs%20for%20free%20then%20we%20could%20solve%20this%20by%20converting%20nullary%20sum%20types%20into%20objects%3A).

Unfortunately I doubt this will be possible. Renaming works if we define the union first as a record and pass that record around (i.e. the way Unionize works): ```ts type...

Potentially related TS issues: - https://github.com/microsoft/TypeScript/issues/41489 - https://github.com/microsoft/TypeScript/issues/41923 - https://github.com/microsoft/TypeScript/issues/45549 🤞 Hopefully it will be fixed in TS soon.