Oliver Joseph Ash

Results 267 comments of Oliver Joseph Ash

Is this the place to check? https://github.com/webdriverio/wdio-sync/blob/32bf88aa30373e50529a2b9cae58573c0a5e6a07/index.js#L592 Look at the object returned from `origFn`? If some heuristic is true, recurse?

@ryanrossiter `props.location` inside the `setTimeout` closure will still be stale. Maybe you're talking about `history.location`, which is mutable unlike `props.location`, however as I mentioned above, React Router discourages this from...

@ryanrossiter https://github.com/ReactTraining/react-router/blob/a1b96d5085053d1e3d67831a75d9a6c76e8dca70/packages/react-router/docs/api/history.md#history-is-mutable

We would love to use Fluture at Unsplash but unfortunately we're blocked by this. Is there anything we can do to help you move this forward?

Workaround (via https://github.com/trivago/prettier-plugin-sort-imports/issues/141): `package.json`: ```json "resolutions": { "@trivago/prettier-plugin-sort-imports/**/@babel/parser": "7.18.5" } ```

Proposal: ```ts export declare function compile(str: string, options?: ParseOptions & TokensToFunctionOptions): P extends object ? PathFunction : PathFunctionWithoutParams; export declare type PathFunctionWithoutParams = () => string; export declare type PathFunction...

I’m frustrated that it doesn't add a new line to my files unless I close and re-open them.

@sindresorhus If it's a new file, when you save it brings up a dialog to ask where you'd like to save. After saving, a new line is not added –...

As far as I can see, the change proposed here wouldn't achieve _full_ type safety because it would still be possible to pass incorrect parameters. Example: ```json { "intlNumber": "Some...

That's certainly the case if it's coming from a backend, but in many cases the strings are defined statically in the code, so this isn't a necessary limitation. In that...