file-hider icon indicating copy to clipboard operation
file-hider copied to clipboard

Hidden files or folders become visible after app restart on iOS

Open victor-onofrei opened this issue 1 year ago • 8 comments

Plugin Version

1.1.1

Obsidian Version

1.4.3 (95)

Affected Platforms

iOS

Expected Behaviour

Files or folders should stay hidden after application restart

Actual Behaviour

Files or folder become visible after application restart

Steps to Reproduce

  1. Hide a file/folder
  2. Restart the application

Workaround: Enable and disable “Hidden File Visibility”

victor-onofrei avatar Apr 03 '23 04:04 victor-onofrei

This is true on Android as well.

t-schreibs avatar Apr 28 '23 20:04 t-schreibs

Happens on Windows as well

RedLilith avatar Jun 06 '23 22:06 RedLilith

This is happening on my Mac as well. Also randomly is hiding my entire vault explorer, then I click unhide, restart Obsidian and everything comes back.

mtzfox avatar Jun 22 '23 06:06 mtzfox

Still an issue on macOS, any ideas on when this can be fixed or what the problem is?

snattack avatar Aug 30 '23 10:08 snattack

android is in da house

farline99 avatar Oct 29 '23 09:10 farline99

I wonder if it's to do with the fact that settings are awaited, then the listener for the file menu is established. This looks like a potential race condition scenario:

https://github.com/Oliver-Akins/file-hider/blob/b9b3e89660fc35382554658b4032a279d5bfc21e/src/main.ts#L22-L25

I could submit a PR for an alternative approach but I'd like some assurance from @Oliver-Akins or another maintainer that they're still maintaining the repo?

janbaykara avatar Jan 07 '24 17:01 janbaykara

@janbaykara - Ohhh, interesting possibility. If you want to make a PR I'll review it, but I'll only validate changes on Linux, so any platform-specific stuff I cannot 100% validate. Though since it seems like this is applicable on most platforms the fix would hopefully be a similar situation.

I'll also probably release #30 at the same time, since that didn't feel like a large enough change to make a new release for.

Oliver-Akins avatar Jan 07 '24 18:01 Oliver-Akins

Great, I'll put in a PR sometime soon!

janbaykara avatar Jan 08 '24 12:01 janbaykara