Olli Etuaho
Olli Etuaho
In some cases there's been variants of the same GPU with different memory but the same model number. Clocks could also vary based on how the card was tuned. Sometimes...
Alternatively we could do this to more closely preserve the previous behavior when `ColorManagement.enabled === false`, though it's kind of unintuitive to apply color management operations in case color management...
I'd lean on applying fog after tone mapping after reading the discussion here. It's a smaller step and we don't have a way to map the fog color to the...
I think the solid color background is implemented as a clear, so it's not subject to tonemapping.
I rebased the PR on top of dev to fix conflicts. I also changed it so that it applies fog after tone mapping, so that the change doesn't have as...
@bhouston @donmccurdy @WestLangley What do you think? 1. Is the current patch ok or should we add some kind of support for blending with the page background first? See #26239...
Sorry about the long delay, but I rebased the patch and added the workaround for non-color-managed scenes to keep the behavior similar to before - I think this is a...
I tried re-running make-screenshot a few times, also with increased time in puppeteer.js, but some of the failing screenshots don't seem to be updating. Maybe there are some platform differences...
I'll try to get around to updating the PR tomorrow! Thanks for getting back to this!
Unfortunately I didn't get to updating the PR today, it'll have to wait until next week!