Oleksii Zaderykhin
Oleksii Zaderykhin
> Are there examples how RegisterPool is used during JIT kernel implementation? @dmitry-gorokhov, yes, currently I am preparing the PR with JIT kernel for Gather operation where this pool is...
> Are there examples how RegisterPool is used during JIT kernel implementation? @dmitry-gorokhov, I added some unit tests, so you could see examples of how the RegisterPool could be used.
> A general question is, why do we need this register pool? Is it to solve any pain point? @ceciliapeng2011 actually yes, there are several pain points. 1. Manual managing...
> Then the regPool itself should be global and unique in the method, right? @ceciliapeng2011 yes, the `regPool` is supposed to be instantiated once in a JIT kernel class or...
> In general this solution looks complicated for such task. Please look at this [solution](https://github.com/openvinotoolkit/openvino/blob/93c94a7637d848ec1426919129c6da6e247ca3c9/src/plugins/intel_cpu/src/nodes/kernels/kernel_utils.hpp#L467) and [usage](https://github.com/openvinotoolkit/openvino/blob/93c94a7637d848ec1426919129c6da6e247ca3c9/src/plugins/intel_cpu/src/nodes/kernels/grid_sample_kernel.cpp). @nshchego, @lohika-denis-kotov actually, this solution is much simpler in use. All complexity is...
> For this purpose there is the wrapper vRefWrap, which do the same. @nshchego so, there is a register pool functionality, but not separated from other staff (the functional could...
> > > Are there examples how RegisterPool is used during JIT kernel implementation? > > > > > > @dmitry-gorokhov, yes, currently I am preparing the PR with JIT...
Hi, @ceciliapeng2011, @nshchego, @maxnick. This PR has 3 approval already. Should I ping someone to initiate merging?
Hi, @dmitry-gorokhov, @ceciliapeng2011, and @maxnick this PR has green CI and 3 approvals. Could someone merge it, please?
Hi, @dmitry-gorokhov, sorry for the delay. Actually, I tried to enable the single-layer tests for the convert operation for the BIN precision. But I had several errors that are not...