node-chunking-streams icon indicating copy to clipboard operation
node-chunking-streams copied to clipboard
verified publisher icon Olegas

Fixes #issue8 - SizeChunker is not wating for chunkStart to finish before running _finishChunk

Open kksharma1618 opened this issue 10 years ago • 4 comments

Fixes issue #8

kksharma1618 avatar Jun 19 '15 06:06 kksharma1618

Ran unit test after the fix. Worked.

screenshot 2015-06-19 12 13 40

kksharma1618 avatar Jun 19 '15 06:06 kksharma1618

:) sorry i missed that part. what do you think now?

kksharma1618 avatar Jun 19 '15 08:06 kksharma1618

Now it is totally broken... Deeper refactoring is required here. We need to split _startIfNeededAndPushData into push and start in a case remainder is 0. I think I can land your first commit in a separate branch and then refactor it further

Olegas avatar Jun 19 '15 12:06 Olegas

Ok. Thanks for looking into it. Nice lib btw.

kksharma1618 avatar Jun 19 '15 12:06 kksharma1618