graceterm icon indicating copy to clipboard operation
graceterm copied to clipboard

Configuration option `DisableTerminationFallback` isn't describe in the readme.md

Open iampluque opened this issue 2 years ago • 1 comments

Hi there!

After looking at the code, I was wondering what scenario you experienced that you needed to set DisableTerminationFallback default value to false, and consequently force close the process?

Thanks

iampluque avatar Jul 07 '22 12:07 iampluque

nvm, I just noticed the comment on top of the props ... Test purpose only

But the question stays: Why do you force close the process?

I mean applicationLifetime.ApplicationStopping is sequential so there might be other libs trying to gracefully cleanup (like in my case gcp pubsub PublisherClient). I understand the reason behind the timeout and the time given to the requests to complete, but the GenericHost (at least in .net 6) next step is to shutdown the server and return a connection close header the upcoming request, then trigger the ApplicationStopped, which also, can be used by other libs

iampluque avatar Jul 08 '22 13:07 iampluque