InfernoTrainer icon indicating copy to clipboard operation
InfernoTrainer copied to clipboard

Customizable Zuk shield direction

Open johnvictorfs opened this issue 3 months ago • 1 comments

Adds a select with a direction for the Zuk shield from when it spawns instead of always being random, but leaves random as the default

This is (imo) useful for practicing quickly a specific strategy you want to use e.g. to offtick the sets based on if the shield is starting on the left or the right, I personally do slightly different things so sometimes I see myself resetting Zuk until I get a specific side just to practice that specific offtick strategy, so I added for myself a config to force it to have it always spawn on a specific direction to practice them individually

What do you think of this change?

image

johnvictorfs avatar Nov 26 '25 20:11 johnvictorfs

Deploy Preview for inferno-trainer ready!

Name Link
Latest commit c795715e3d5cc070e668db178b531d3f0e92d7b7
Latest deploy log https://app.netlify.com/projects/inferno-trainer/deploys/692b21b9e554c30008a20a0c
Deploy Preview https://deploy-preview-300--inferno-trainer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 26 '25 20:11 netlify[bot]

Just a nit: there are a lot of defaults here. IMO it makes the most sense to set the default on the configuration and expect it's set as you pass it down to ZukShield.ts rather than defaulting to random at each point. Not a big deal though, thanks for contributing!

That's true, thanks! Changed in https://github.com/OldSchoolSDK/InfernoTrainer/pull/300/commits/c795715e3d5cc070e668db178b531d3f0e92d7b7 to remove the default from ZukShield

johnvictorfs avatar Nov 29 '25 16:11 johnvictorfs