InfernoTrainer
InfernoTrainer copied to clipboard
fix: inferno scene vertical offset
May need height adjustment for player as well?
Deploy Preview for inferno-trainer ready!
| Name | Link |
|---|---|
| Latest commit | e3cc442596ecd22d57bc300b4337f8d7f0be7bd6 |
| Latest deploy log | https://app.netlify.com/projects/inferno-trainer/deploys/68fe9bd6d7f3ed0008ad07f1 |
| Deploy Preview | https://deploy-preview-298--inferno-trainer.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Honestly, this doesn't seem like an improvement. The character's shoes are sinking into the floor. Is that what you meant by "may need height adjustment for player as well?"
What is this trying to accomplish?
The tile markers render floating above the scene, suggesting the vertical offset is set incorrectly.
To fix the player height, we should be able to pass the option { verticalOffset: -0.4525 } here: https://github.com/OldSchoolSDK/osrs-sdk/blob/main/src/sdk/Player.ts#L973
I see, can the tile markers vertical offset be changed? How do the mobs look?