InfernoTrainer icon indicating copy to clipboard operation
InfernoTrainer copied to clipboard

fix: inferno scene vertical offset

Open cboar opened this issue 1 month ago • 4 comments

verticaloffset

May need height adjustment for player as well?

cboar avatar Oct 26 '25 22:10 cboar

Deploy Preview for inferno-trainer ready!

Name Link
Latest commit e3cc442596ecd22d57bc300b4337f8d7f0be7bd6
Latest deploy log https://app.netlify.com/projects/inferno-trainer/deploys/68fe9bd6d7f3ed0008ad07f1
Deploy Preview https://deploy-preview-298--inferno-trainer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Oct 26 '25 22:10 netlify[bot]

Honestly, this doesn't seem like an improvement. The character's shoes are sinking into the floor. Is that what you meant by "may need height adjustment for player as well?"

What is this trying to accomplish?

dereklopes avatar Nov 03 '25 03:11 dereklopes

The tile markers render floating above the scene, suggesting the vertical offset is set incorrectly. To fix the player height, we should be able to pass the option { verticalOffset: -0.4525 } here: https://github.com/OldSchoolSDK/osrs-sdk/blob/main/src/sdk/Player.ts#L973

cboar avatar Nov 04 '25 00:11 cboar

I see, can the tile markers vertical offset be changed? How do the mobs look?

dereklopes avatar Nov 05 '25 01:11 dereklopes