okuna-api icon indicating copy to clipboard operation
okuna-api copied to clipboard

Prevent community type changing from private to public

Open uiboy opened this issue 5 years ago • 4 comments

Until we figure out how to gracefully make this transition without compromising privacy of posts/comments in a private community. We should prevent changing communities from private -> public for creators/admins.

The reverse , ie from public to private can be continued to be allowed.

uiboy avatar Jan 13 '20 09:01 uiboy

PR https://github.com/OkunaOrg/okuna-api/pull/672

uiboy avatar Jan 13 '20 14:01 uiboy

On the app-side it would probably be good to have a small (but conspicuous) warning that "A private community cannot currently be made public at a later date" on the community settings page. Just to clearly notify people about this.

Komposten avatar Jan 13 '20 16:01 Komposten

AFAIK this is done, should we close this?

lifenautjoe avatar May 16 '20 12:05 lifenautjoe

AFAIK this is done, should we close this?

Probably. We should probably also open a new issue in okuna-app about improving the related UI a bit, though:

Creating a community:

  • Maybe make the text more conspicuous (not sure if needed).

Editing a community:

  • Disable the Public/Private control. Right now you can change it to Public while editing, only to get an error toast saying "a private community may not be changed to public" when you try to save.
  • We should probably also change the text below the control to e.g. "A private community cannot be made public" since the current text says "cannot later change". Note: Talking about only changing the text shown when editing a community.

Komposten avatar May 16 '20 18:05 Komposten