falcon icon indicating copy to clipboard operation
falcon copied to clipboard

Use Dart Sass Implementation instead of Node SASS

Open Dreimus opened this issue 1 year ago • 3 comments

Hello,

Did you considered using dart sass instead of node sass implementation ?

It reduce compilation timing and assure a long term support for sass features.

Thanks

Dreimus avatar Oct 13 '22 09:10 Dreimus

Hi @Dreimus,

Actually we moved from node-sass to dart sass in develop branch recently. Dart sass performance is worse than node-sass but there is sass-embedded package that improves performance https://github.com/Oksydan/modern-prestashop-starter-theme/commit/e210f8bca400d8cb738db78790a806859f7873c8.

By default we are using sass instead of sass-embedded coz of CI I had implemented recently on dev branch. I will be trying to make CI working with sass-embedded.

Oksydan avatar Oct 13 '22 11:10 Oksydan

Thanks for your feeback ! When do you think the v3 will be released ?

Dreimus avatar Oct 14 '22 13:10 Dreimus

I am planning to release new version day after prestashop 8.0 release.

Oksydan avatar Oct 14 '22 14:10 Oksydan