falcon icon indicating copy to clipboard operation
falcon copied to clipboard

Trying to access array offset on value of type null

Open Olimbot opened this issue 2 years ago • 3 comments

Hi @Oksydan This plugin and your excellent theme work fine with PHP 7.3 but there are some trouble with PHP 7.4.

I replace in template is_shoppingcart.tpl and modal-success.tpl : {if $subtotal.value} By {if isset($subtotal.value)}

And it's works.

Regards, Olivier

Olimbot avatar Dec 21 '21 15:12 Olimbot

Hi @Olimbot, Thank you for your report. I am going to fix it with version 2.1.0 of theme. I am going to remove every dependencies module override inside theme. Since it forces me to release new version of starter every time module template requires some work.

Oksydan avatar Dec 21 '21 23:12 Oksydan

Hi @Oksydan, Thanks for your feedback. I think it's a good idear and more simple to maintain. Regards,

Olimbot avatar Dec 22 '21 16:12 Olimbot

Hi @Olimbot,

this issue got lost somewhere in module issue tab 😕. Right now it is only possible to post issues on main starter repo.

This problem has been fixed and will be released with 3.0 version of starter. Module has been update accordingly.

Oksydan avatar Oct 10 '22 21:10 Oksydan