laravel-table icon indicating copy to clipboard operation
laravel-table copied to clipboard

V5

Open Okipa opened this issue 3 years ago • 3 comments

Okipa avatar Feb 13 '22 12:02 Okipa

I love the commits messages 😄

RSickenberg avatar Mar 30 '22 12:03 RSickenberg

@RSickenberg, here are some serious WIP commits here ! 🛠️

Okipa avatar Mar 30 '22 12:03 Okipa

@Okipa I never took the WIP this seriously until now! 💪🏼 , keep up the good work!

RSickenberg avatar Mar 30 '22 12:03 RSickenberg

Would you welcome a sed command that patches Larastan in CI?

szepeviktor avatar Aug 28 '22 20:08 szepeviktor

Here you are.

sed -i -e 's#.*protected \$enablesPackageDiscoveries.*#&\nprotected function overrideApplicationBindings($app){return["livewire"=>"Livewire\\\\LivewireManager"];}#' vendor/nunomaduro/larastan/src/ApplicationResolver.php

szepeviktor avatar Aug 28 '22 21:08 szepeviktor

💡 One of your computers has a non-GitHub email address set in git.

(many commits do not have your profile icon)

szepeviktor avatar Aug 28 '22 21:08 szepeviktor

Target class [livewire] does not exist.

This branch also has this error with Laravel v9.

https://github.com/Okipa/laravel-table/pull/98#issuecomment-1230309188 👀

szepeviktor avatar Sep 03 '22 13:09 szepeviktor

@szepeviktor, Yes, this is still the same unfixed Issue, unfortunately nor Larastan or Livewire opened discussions did got answers allowing to fix it.

Okipa avatar Sep 03 '22 13:09 Okipa

Changing the order of service provider registration would solve it.

szepeviktor avatar Sep 03 '22 13:09 szepeviktor

Changing the order of service provider registration would solve it.

In the TestCase? I tested that and it didn't change anything unfortunately.

Livewire is loaded before Laravel Table currently => https://github.com/Okipa/laravel-table/blob/v5/tests/TestCase.php#L46

Okipa avatar Sep 03 '22 14:09 Okipa

Livewire is loaded before Laravel Table currently

Yes. It seems like. But the stack trace tells otherwise: https://github.com/Okipa/laravel-table/pull/98#issuecomment-1230309188

szepeviktor avatar Sep 03 '22 16:09 szepeviktor

Yes. It seems like. But the stack trace tells otherwise: #98 (comment)

Well, it seems that I have no way to control the order of the service providers registration, isn't it ?

Okipa avatar Sep 03 '22 19:09 Okipa

I was researching it without results. There must be a Laravel forum where there are people with knowledge of Laravel internals.

szepeviktor avatar Sep 03 '22 19:09 szepeviktor

This would patch Larastan https://github.com/Okipa/laravel-table/pull/81#issuecomment-1229552922 until you reverse the order of service provider loading.

szepeviktor avatar Sep 05 '22 10:09 szepeviktor