Rythm.js icon indicating copy to clipboard operation
Rythm.js copied to clipboard

Expose a connectExternalStream() function

Open Okazari opened this issue 8 years ago • 3 comments

https://github.com/Okazari/Rythm.js/blob/e1c7d751b54e0b89d6d61b8f12015a23ee605b90/src/Player.js#L60 Externalise this arrow function into a connectStreamSource(), expose it in the api and add it to the documentation

Okazari avatar Sep 05 '17 15:09 Okazari

Here I was hoping for an evening of helping to close up this ticket for you and you already seem to have it implemented. It looks like your work from 33274ee and onwards has resolved this ticket - let's close it up! ;)

nesvand avatar Jan 13 '18 13:01 nesvand

In my opinion connectSource is a bit too "low level". It's intented to connect an already created AudioSource to rythm.

What i would love to give as API is more like connectExternalStream (I think the issue name have a mistake, i will update it) which is nothing more than the function given to .then() in the linked line.

WDYT ?

Okazari avatar Jan 13 '18 13:01 Okazari

Sure let me think on it - I'll re-familiarise myself with the project (as it has been updated a bit since I last checked!) ;)

nesvand avatar Jan 14 '18 05:01 nesvand