OpenAI-API-dotnet icon indicating copy to clipboard operation
OpenAI-API-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon OkGoDoIt

Feature/small improvements

Open Alexei000 opened this issue 4 years ago • 1 comments

This PR does not add any new functionality, but makes a series of improvements:

  • unifies similar code, by creating helpers for requests and responses.
  • adds tests (mostly integrative since they reach OpenAI) for most (if not all) existing functionality.
  • solve multiple issues reported by Resharper (code analysis).

My intention is to be more DRY and make future developments easier.

Alexei000 avatar Jun 20 '21 20:06 Alexei000

Hello! Is there any chance for this to get checked? I would really like to see this project going further. Thanks.

Alexei000 avatar Oct 23 '21 07:10 Alexei000

@Alexei000 -- the endpoints have already been changed in another commit. can you updated this PR based on a diff to the most recent version?

gotmike avatar Feb 01 '23 02:02 gotmike

@OkGoDoIt -- what do u think on this?

gotmike avatar Feb 01 '23 16:02 gotmike

Thanks @Alexei000 ! Due to a lot of code changes between your PR and now, I wasn't able to easily merge your PR so I manually added your new tests and code cleanup to https://github.com/OkGoDoIt/OpenAI-API-dotnet/commit/82df6fb55186d3c374db4abd9a78939d6b0ad039. Thank you for your help!

OkGoDoIt avatar Feb 03 '23 02:02 OkGoDoIt