EvenMoreFish icon indicating copy to clipboard operation
EvenMoreFish copied to clipboard

Fish biome sets

Open LeeSpork opened this issue 3 years ago • 2 comments

I've decided to make usage of the biome-specific fish feature to add more variation to fishing on my server, however I've noticed an issue: it requires a lot of copy-paste if you want to make multiple fish in the same biomes. This could be a problem if, for example, Mojang decides to add another ocean biome, and now I'd have to go through all of my fish and hope that I don't miss any fish.

Here's my proposed solution, expressed as example config files:

biomesets.yml (new file)

biomesets:
  Oceans:
    biomes:
      - BEACH
      - SNOWY_BEACH
      - STONE_SHORE
      - MUSHROOM_FIELD_SHORE
      - OCEAN
      - DEEP_OCEAN
      - COLD_OCEAN
      - DEEP_COLD_OCEAN
      - FROZEN_OCEAN
      - DEEP_FROZEN_OCEAN
      - LUKEWARM_OCEAN
      - DEEP_LUKEWARM_OCEAN
      - WARM_OCEAN
      - DEEP_WARM_OCEAN
  Deserts:
    biomes:
      - DESERT
      - DESERT_HILLS
      - DESERT_LAKES
  Ender:
    biomes:
      - THE_END
      - END_BARRENS
      - END_HIGHLANDS
      - END_MIDLANDS

fish.yml (snippets)

    Sea Bass:
      biomesets:
        # Can only be caught in oceanic biomes (see biomesets.yml)
        - Oceans

    Ender Pearl Oyster:
      item:
        material: ENDER_PEARL
      biomesets:
        # Can be caught in Ender biomes
        - Ender
      biomes:
        # Can also be caught in the void biome
        - THE_VOID

The way it would work is it would act as if the biomes referenced in the biomesets were also in the biomes field of the fish

Maybe it could also be cool to make dimension specific fish? (e.g. so you can specify that fish can only be caught in the Overworld dimension, so they can't be caught in the End regardless of biome)

LeeSpork avatar Sep 09 '21 21:09 LeeSpork