OhadRubin

Results 36 comments of OhadRubin

>Apart from the "French" -- "France" example, where else could teacher forcing fail? If for example the entire beam contains multiple representations of the same logical form tree (think about...

Yes, we are training just on the 7000 examples of train_spider.json to get to SOTA. I was meaning to get to adding spider_others.json examples and I was really busy with...

If anyone is interested in adding it, I would be very very grateful.

> > Yes, we are training just on the 7000 examples of train_spider.json to get to SOTA. I was meaning to get to adding spider_others.json examples and I was really...

Great. let me know how it does on the dev set. There's a bit of code duplication here, but we can solve this later.

Hey, try to modify the following line: https://github.com/OhadRubin/SmBop/blob/d325a277ee20d6dc3e2736d323c5d3ca559f72d4/smbop/utils/moz_sql_parser/sql_parser.py#L40. Set it to around 4000 maybe.

> In the paper, it mentions that the score is defined as follow. Is that calculated by summing the logprob of each token of the ground true y conditioned on...

Hey, this might be related to the fact that you are using a single gpu, the DPR setup benefits greatly from a large batch size. The result of 31.9% LFEM...