script-lab icon indicating copy to clipboard operation
script-lab copied to clipboard

Should prompt if importing an external gist that's already been imported before

Open nico-bellante opened this issue 7 years ago • 5 comments

Description:

Right now, if you import a gist via the import field three times, this will appear as 3 separate gists locally. This should go through the same pipeline as the opening your own gist goes through where it checks to see if it exists locally first.

Additionally, if a user imports their own gist while not signed in, then signs in, they should be able to update that gist.

nico-bellante avatar Nov 07 '18 19:11 nico-bellante

@Zlatkovsky which milestone do you think this should fall under?

nico-bellante avatar Nov 07 '18 20:11 nico-bellante

Actually, moving it up a bit to "polish", since it seems like this could get quite confusing/annoying (I, for one, often copy-paste the GUIDs of my snippets rather than use the list).

Zlatkovsky avatar Nov 08 '18 23:11 Zlatkovsky

Also, we had actually announced improvements to this space in https://developer.microsoft.com/en-us/office/blogs/announcing-script-lab-improvements/ a year ago. So we shouldn't make the experience less good (or at least, not for long)

Zlatkovsky avatar Nov 14 '18 17:11 Zlatkovsky

Does today's SL have this functionality?

nico-bellante avatar Dec 22 '18 03:12 nico-bellante

@nico-bellante, yes. See the blog mentioned above, or just try it out. Essentially for each snippet, we store what its original source (Gist + userid) and ID (gist ID) was, and if you import it again, we prompt you.

Zlatkovsky avatar Dec 24 '18 19:12 Zlatkovsky

Obsolete.

It's easier to have a clear boundary between internal and external.

We will always make a copy for a new import.

wandyezj avatar Apr 09 '24 22:04 wandyezj