script-lab-2017
script-lab-2017 copied to clipboard
OfficeDev
README details on using external libraries + some reorganization
I added a bunch of detail on how to use external libraries, and also used this as an opportunity for some minor reorganization.
Could one of you take a look and see if it all makes sense and is grammatically sound? @WrathOfZombies, could you also help make sure I'm using the right terminology and explanation of the various types of modules? Thanks!
Would you want to split this readme into Wiki's instead? It would be easier to consume and only look for what you want thanks to a TOC.
Is it worth talking about nested library dependencies and how they get loaded? My assumption is that this is all automatic like a normal npm package, but I'm curious if there are cases where you need to add the nested dependencies to the Library list.
Wikis are great but I found wiki not so portable (compared to md files). When I was doing MS Graph samples we used shared wiki to point ppl to small how to this and that. Keeping track of them was a pain too.
From: Bhargav Krishna [mailto:[email protected]] Sent: Friday, April 28, 2017 12:53 PM To: OfficeDev/script-lab [email protected] Cc: Siew Moi Khor [email protected]; Review requested [email protected] Subject: Re: [OfficeDev/script-lab] README details on using external libraries + some reorganization (#391)
Would you want to split this readme into Wiki's instead? It would be easier to consume and only look for what you want thanks to a TOC.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/script-lab/pull/391#issuecomment-298091497, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJ-LPNrcUGTb9lWcnN3f04t1wkez2cPEks5r0kOMgaJpZM4NL3Im.
Also, what version(s) of ES does ScriptLab support? I'm assuming ES5/6 yes and ES7 no. Is it the same as Edge, IE, or Chrome? Chakra?
@siewmoi Could you explain what you meant by port? Where are we porting them to? Also why would we port something on this repository elsewhere?
@WrathOfZombies - if we don't foresee a need to port, then it's ok to use wiki.
some background: wrt to our MS Graph samples, we had many repos, one for each platform, etc and to top it they were also getting started samples on dev.office.com. We used the wiki during preview and had to move to dev.office.com repo at GA.