office-js-helpers icon indicating copy to clipboard operation
office-js-helpers copied to clipboard

authenticator.authenticate appends extra parameter action=displayDialog in URL

Open erfaan opened this issue 6 years ago • 8 comments

Code:

    authenticator
    .authenticate(OfficeHelpers.DefaultEndpoints.Google)
    .then(function (token) {
        console.log(token);
    })
    .catch(function (error) {
        console.log(error);
    });

A new tab is opened in Safari with URL:

https://accounts.google.com/o/oauth2/v2/auth?response_type=token&client_id=XXXXXXXX&redirect_uri=https%3A%2F%2FXXXXXXXXX&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fplus.me&resource=https%3A%2F%2Fwww.googleapis.com&state=XXXXXXXXX&action=displayDialog

And Google shows this error: screen shot 2018-04-14 at 9 04 08 pm

erfaan avatar Apr 14 '18 16:04 erfaan

Will take a look and get back. What client are you using?

WrathOfZombies avatar Apr 17 '18 08:04 WrathOfZombies

I am using Outlook 16.11 (180311) on MacOS High Sierra (10.13.4)

erfaan avatar Apr 17 '18 09:04 erfaan

We are calling this code and seeing the same issue. Is there a fix for this bug? We are doing Outlook 16.13.1(180523) and macOS High Sierra (10.13.3).

CodingFanSteve avatar Jun 13 '18 00:06 CodingFanSteve

Same here. Unable to authenticate. But in Excel.

sstepper avatar Jun 29 '18 23:06 sstepper

I have exact same problem. I am developing PowerPoint Add-in.

KrzysiekKuczma avatar Aug 30 '18 08:08 KrzysiekKuczma

I have the same problem on MAC OS X Word 16 with the same exact error.

alirezastack avatar Feb 05 '19 13:02 alirezastack

Is this fixed yet ? I have the same problem but then for dropbox. React project.

ONataLux avatar Apr 03 '19 11:04 ONataLux

We've also spent ages trying to solve this problem, it's really quite silly that this happens as it can have a very bizzare and unexpected impact. For example, if your site is using code igniter then having an 'action' GET param breaks everything as it's a keyword in that framework.

johnrhunt avatar Sep 20 '19 15:09 johnrhunt