microsoft-teams-apps-requestateam icon indicating copy to clipboard operation
microsoft-teams-apps-requestateam copied to clipboard

Next Button on Add Members screen will not do anything

Open Luxosity opened this issue 2 years ago • 2 comments

Description

After clicking the button (btnNextAddMembers.) on the Add Members screen (scrnBuildNew) after I added both owners, nothing happens. If I go to My Requests screen (scrnMyRequests) and go to that draft and click edit, I am able to add owners and click on the Submit Updates button (btnSubmitUpdates_EditRequest) and submit it successfully that way.

Steps to reproduce

  1. Open App
  2. Build New
  3. Enter Private for visibility
  4. Next
  5. Enter Team name and check availability. No team name conflicts
  6. Enter description and business reason
  7. Next
  8. Add myself and another admin to owners.
  9. Next
  10. Nothing Happens.

Expected results

I expect to move onto the final screen after Add Members screen to submit the team creation but next button doesn't do anything on the Add Members screen

Actual Results

After clicking Next on the add members screen, nothing happens.

Solution component

Power App

Operating system (environment)

Windows

Additional Info

**btnSubmitUpdates_EditRequest code is at bottom**

btnNextAddMembers code:

If(
    ('cmbOwners._1'.Selected.Email = 'cmbOwners._2'.Selected.Email) && (CountRows('cmbOwners._1'.SelectedItems) > 0),
    Set(
        Varowandmemnotclash,
        false
    ),
    Set(
        Varowandmemnotclash,
        true
    )
);
If(
    (CountRows('cmbMembers.'.SelectedItems) > 0) && (CountRows('cmbOwners._1'.SelectedItems) > 0) && (CountRows('cmbOwners._2'.SelectedItems) > 0),
    If(
        'cmbOwners._1'.Selected.Email = First('cmbMembers.'.SelectedItems).Email || 'cmbOwners._1'.Selected.Email = Last('cmbMembers.'.SelectedItems).Email || 'cmbOwners._2'.Selected.Email = First('cmbMembers.'.SelectedItems).Email || 'cmbOwners._2'.Selected.Email = Last('cmbMembers.'.SelectedItems).Email,
        Set(
            Varowandmemnotclash,
            false
        ),
        Set(
            Varowandmemnotclash,
            true
        )
    )
);
If(
    CountRows('cmbOwners.'.SelectedItems) <> 2 || (CountRows('cmbOwners._1'.SelectedItems) < 1) || (CountRows('cmbOwners._2'.SelectedItems) < 1),
    Set(
        BNReviewAndSubmit,
        false
    ) && Set(
        BNMembership,
        true
    ),
    If(
        CountRows('cmbOwners.'.SelectedItems) = 2 && Varowandmemnotclash,
        UpdateContext({ScratchlocalStep: ScratchlocalStep + 1}) && Set(
            BNReviewAndSubmit,
            true
        ) && Set(
            BNMembership,
            false
        )
    )
);
If(
    CountRows('cmbOwners.'.SelectedItems) = 2 && (CountRows('cmbOwners._1'.SelectedItems) > 0) && (CountRows('cmbOwners._2'.SelectedItems) > 0) && Varowandmemnotclash,
    Patch(
        'Teams Requests',
        LookUp(
            'Teams Requests',
            RowKey = srowkey
        ),
        {Owners: 'cmbOwners.'.SelectedItems},
        {Members: 'cmbMembers.'.SelectedItems},
        {
            Stage: {
                '@odata.type': "#Microsoft.Azure.Connectors.SharePoint.SPListExpandedReference",
                Value: "Requirements"
            }
        }
    )
);
--------------------------------------------------------------------------------------------------------------------------------
btnSubmitUpdates_EditRequest code

If(
    (dcvOwners_EditRequest_1.Selected.Email = dcvOwners_EditRequest_2.Selected.Email) && (CountRows(dcvOwners_EditRequest_1.SelectedItems) > 0),
    Set(
        Vareditowandmemnotclash,
        false
    ),
    Set(
        Vareditowandmemnotclash,
        true
    )
);
If(
    (CountRows(dcvMembers_EditRequest.SelectedItems) > 0) && (CountRows(dcvOwners_EditRequest_1.SelectedItems) > 0) && (CountRows(dcvOwners_EditRequest_2.SelectedItems) > 0),
    If(
        dcvOwners_EditRequest_1.Selected.Email = First(dcvMembers_EditRequest.SelectedItems).Email || dcvOwners_EditRequest_1.Selected.Email = Last(dcvMembers_EditRequest.SelectedItems).Email || dcvOwners_EditRequest_2.Selected.Email = First(dcvMembers_EditRequest.SelectedItems).Email || dcvOwners_EditRequest_2.Selected.Email = Last(dcvMembers_EditRequest.SelectedItems).Email,
        Set(
            Vareditowandmemnotclash,
            false
        ),
        Set(
            Vareditowandmemnotclash,
            true
        )
    )
);
If(
    CountRows(dcvOwners_EditRequest.SelectedItems) <> 2 || CountRows(dcvMembers_EditRequest.SelectedItems) >= 2 || (dcvVisibility_EditRequest.Selected.Value = "Select" || CountRows(dcvVisibility_EditRequest.SelectedItems) < 1) || (IsBlank(Trim(dcvTeamDescription_EditRequest.Text))) || (IsBlank(Trim(dcvBusinessJustification_EditRequest.Text))),
    Set(
        EditRequest,
        true
    ) && Set(
        EJustificationValidation,
        "Business reason can't be empy"
    ) && Set(
        EditRequest,
        true
    ) && Set(
        EDescription,
        "Description can't be empty"
    ) && Set(
        EVisibilityValidation,
        "Select a Visibility option"
    )
);
If(
    CountRows(dcvOwners_EditRequest.SelectedItems) = 2 && (!IsBlank(Trim(dcvBusinessJustification_EditRequest.Text))) && (!IsBlank(Trim(dcvTeamDescription_EditRequest.Text))) && (dcvVisibility_EditRequest.Selected.Value <> "Select" && CountRows(dcvVisibility_EditRequest.SelectedItems) > 0) && Vareditowandmemnotclash && (CountRows(dcvOwners_EditRequest_1.SelectedItems) > 0) && (CountRows(dcvOwners_EditRequest_2.SelectedItems) > 0),
    Set(
        changetosubmit,
        true
    ) && SubmitForm(frmEditRequest) && Notify(
        "Success! Request submitted.",
        NotificationType.Success
    ) && Set(
        EditRequest,
        false
    )
);
If(
    (!IsBlank(Trim(dcvBusinessJustification_EditRequest.Text))) && (!IsBlank(Trim(dcvTeamDescription_EditRequest.Text))) && (dcvVisibility_EditRequest.Selected.Value <> "Select" && CountRows(dcvVisibility_EditRequest.SelectedItems) > 0 && CountRows(dcvOwners_EditRequest.SelectedItems) = 2 && Vareditowandmemnotclash && (CountRows(dcvOwners_EditRequest_1.SelectedItems) > 0) && (CountRows(dcvOwners_EditRequest_2.SelectedItems) > 0)),
    ClearCollect(
        TeamsReqTable,
        Filter(
            'Teams Requests',
            'Created By'.Email = gblUserProfile.mail
        )
    )
);

Luxosity avatar Mar 28 '22 22:03 Luxosity

@Luxosity Did you remove and re-add the data sources after you imported the app? Thanks

alexc-MSFT avatar Jun 08 '22 20:06 alexc-MSFT

Another idea, I noticed that there is still an old check on the Button, that does not allow more then 2 Members (not Owners). If you add more then that, the Button just doesn't do anything. When you edit the entry afterwards, you are basically circumventing the If check on that button on the Form, that's why it works.

It is this part : CountRows(dcvMembers_EditRequest.SelectedItems) >= 2

If this is the case, maybe we can either remove that limitation on the Submit Button for a max of 2 Members, or display a Message on the Form telling the user that they can only add 2 Members upon creation ?

Leviani avatar Dec 14 '22 18:12 Leviani