BotBuilder-MicrosoftTeams
BotBuilder-MicrosoftTeams copied to clipboard
[Node] Change signature of startReplyChain to reduce possibility of dev error
The current signature for startReplyChain is prone to dev error, as what's conceptually the same information could be passed in multiple locations:
- message.address.serviceUrl vs serviceUrl parameter
- message.address.conversation.id vs. channelId parameter The function can fail to return a valid address if the parameters contain inconsistent/incomplete information.
It would be better if the parameters to startReplyChain were parallel to startConversation. startReplyChain(message: IMessage|IIsMessage, done: (err: Error, address?: IAddress) => void) where the message's address contains all the necessary routing information.
@BillZengMSFT Please take a look.