BotBuilder-MicrosoftTeams icon indicating copy to clipboard operation
BotBuilder-MicrosoftTeams copied to clipboard

[Node] Change signature of startReplyChain to reduce possibility of dev error

Open aosolis opened this issue 7 years ago • 1 comments

The current signature for startReplyChain is prone to dev error, as what's conceptually the same information could be passed in multiple locations:

  • message.address.serviceUrl vs serviceUrl parameter
  • message.address.conversation.id vs. channelId parameter The function can fail to return a valid address if the parameters contain inconsistent/incomplete information.

It would be better if the parameters to startReplyChain were parallel to startConversation. startReplyChain(message: IMessage|IIsMessage, done: (err: Error, address?: IAddress) => void) where the message's address contains all the necessary routing information.

aosolis avatar Sep 14 '17 23:09 aosolis

@BillZengMSFT Please take a look.

RamjotSingh avatar Sep 15 '17 23:09 RamjotSingh