online-nilm icon indicating copy to clipboard operation
online-nilm copied to clipboard

ignore the last window size?

Open Hessen525 opened this issue 5 years ago • 1 comments

Hi, @OdysseasKr Thanks for your work. gen_batch(chunk.iloc[:,1], chunk.iloc[:,0], chunk.shape[0]-window_size, 0, window_size) in gen.py. Why not chunk.shape[0]-window_size+1?

ex: batch size: 5, window_size = 2, the number of sliding windows should be 5-2+1=4 if I understand correctly,

Thanks.

Hessen525 avatar Feb 24 '20 07:02 Hessen525

You are indeed correct on that, I will fix that as soon as possible.

OdysseasKr avatar Mar 01 '20 12:03 OdysseasKr