chainquery icon indicating copy to clipboard operation
chainquery copied to clipboard

Put support_type into Support table

Open melroy89 opened this issue 6 years ago • 2 comments

Hi,

Its very hard to figure out if a row in the support table is actually just 'support' or really a 'tip'. My proposal would be to introduce support_type (I don't care which database type it will be, could be an int or enum or ...).

As long as you can easily distinguish if the support is a tip or a support (or whatever LBRY could have in the future as well).

Regards, Melroy van den Berg

melroy89 avatar Sep 09 '19 01:09 melroy89

There's really no clean way to tell right now except for looking at the claim address, which historically may be different and could potentially change (guess we can still track at time of tx). The blockchain team is working on introducing metadata for supports, so we can then mark them appropriately among other cool things we can start to utilize the metadata for (i.e comments, ratings, subscriptions, signed supports)

tzarebczan avatar Sep 09 '19 01:09 tzarebczan

Yeah, agreed with @tzarebczan here. There is no really accurate way to do this right now.

tiger5226 avatar Sep 11 '19 00:09 tiger5226