ReduxSimple icon indicating copy to clipboard operation
ReduxSimple copied to clipboard

Reliance on Converto / Newtonsoft.Json

Open slimshader opened this issue 3 years ago • 3 comments

Hi,

I just ported this awesome library to Unity (and works like a charm so far) but was hoping to further remove the dependence on Converto for (IsDeepEqual calls) which in turn depends on outdated version of Newtonsoft.Json. My question: if my state is a record, so I know the comparisons are deep, can this code be simplified to not rely on IsDeepEqual?

slimshader avatar Sep 15 '22 12:09 slimshader

I am glad it works great on Unity.

Since we now have System.Text.Json, I believe we can remove the dependency from Newtonsoft. I will take a look when I have some free time.

Odonno avatar Sep 29 '22 11:09 Odonno

Any update on this?

th3d0g avatar Feb 08 '24 21:02 th3d0g

Hi @slimshader . Is it possible to share some thoughts on porting to Unity? There are to many allocations in ReduxSimple's implmentation. While this is not a thing in WPF or other platforms, in Unity we tend to minimize heap alloc. So how do you manage to do it?

Odaimoko avatar Jun 09 '24 05:06 Odaimoko