react-native-lanscan icon indicating copy to clipboard operation
react-native-lanscan copied to clipboard

fetchInfo has 1 arg

Open timscott opened this issue 8 years ago • 1 comments

I'm getting this error:

RNLANScan.fetchInfo got 0 arguments, expected 1
invoke
    BaseJavaModule.java:290
call
    NativeModuleRegistry.java:187
call
    NativeModuleRegistry.java:62
call
    CatalystInstanceImpl.java:432
run
    NativeRunnableDeprecated.java:-2
handleCallback
    Handler.java:739
dispatchMessage
    Handler.java:95
dispatchMessage
    MessageQueueThreadHandler.java:31
loop
    Looper.java:148
run
    MessageQueueThreadImpl.java:196
run
    Thread.java:818

The error is here: https://github.com/Odinvt/react-native-lanscan/blob/f9185b65163a3dad4ba6ce8704c7183ec971386a/main.js#L105

You can see that the method has one arg here: https://github.com/Odinvt/react-native-lanscan/blob/f9185b65163a3dad4ba6ce8704c7183ec971386a/android/src/main/java/com/odinvt/lanscan/LANScanModule.java#L79

timscott avatar Oct 28 '16 22:10 timscott

Yes gosh can't believe I did that haha.. That's what happens when you don't do TDD on something.. thanks for your feedback Tim ! That's very appreciated 👍 👍 Will fix ASAP

Odinvt avatar Oct 28 '16 22:10 Odinvt