OverrideAudit icon indicating copy to clipboard operation
OverrideAudit copied to clipboard

[FEATURE] Add packages to ignored_packages while working on them

Open OdatNurd opened this issue 7 years ago • 3 comments

Summary

For any operation that modifies the contents of a package (delete override, cleanup, cleanup of case issues, etc) the package or packages in question should probably be inserted into the list of ignored packages prior to doing the operation, and then removed once they're done.

Some work would have to be done to make sure that this doesn't trigger an automated expiration check when the packages are removed from the list while still making sure that if other operations are happening in the meantime (e.g. something being upgraded or the user un-ignoring something manually) still would.

Possibly this could be done by extending AutoReportTrigger with some static methods you could call to give it a list of packages, and it would add them to the ignored list and take them out, tracking which they were so that it would know it doesn't need to trigger a check.

Questions

This would need to happen if a package directory or override was renamed due to case issues, because the only way to do that is to move the file away to a different name and back (otherwise the underlying OS assumes you're trying to rename a file to itself).

In what other cases would this be needed?

OdatNurd avatar Apr 10 '17 18:04 OdatNurd

This would also be useful when deleting an override because ST doesn't reload the original - https://github.com/SublimeTextIssues/Core/issues/922

keith-hall avatar Apr 10 '17 18:04 keith-hall

Ah yeah, good catch. I think I had that in the back of my head somewhere previously.

The issue doesn't say specifically, but I assume the lack of reloading happens for everything and not just python plugins, right?

OdatNurd avatar Apr 10 '17 20:04 OdatNurd

The issue doesn't say specifically, but I assume the lack of reloading happens for everything and not just python plugins, right?

I'm not about everything - for example, .tmPreferences files seem to be unaffected, but it definitely also happens for .sublime-settings files.

keith-hall avatar Apr 14 '17 12:04 keith-hall