go-octopusdeploy icon indicating copy to clipboard operation
go-octopusdeploy copied to clipboard

support for automation environment and tool data on useragent

Open benPearce1 opened this issue 2 years ago • 3 comments

[sc-31593]

benPearce1 avatar Nov 23 '22 01:11 benPearce1

This pull request has been linked to Shortcut Story #31593: Add telemetry to the CLI vNext.

Thinking out loud here: Maybe we should consider using context instead of parameter passing for the tool information? A good rule of thumb is that any data required for a function to run should be passed as parameters. In this case (however), it's contextual info.

@domenicsim1 thoughts?

jbristowe avatar Nov 25 '22 02:11 jbristowe

Maybe we should consider using context instead of parameter passing for the tool information? A good rule of thumb is that any data required for a function to run should be passed as parameters. In this case (however), it's contextual info.

I am by far not an expert here, but it seems that context is analogous to a cancellation token, with the ability to pass key/value data with it, for example the context of a http request that allows the request to be cancelled during execution.

benPearce1 avatar Nov 25 '22 02:11 benPearce1