OctoPack
OctoPack copied to clipboard
OctopusDeploy
Improves unit test results stability across runs
This pull request makes some changes to the unit tests of this project to improve the stability of test results across test runs.
In addition, OctoPack installation/uninstallation integration tests were added to ensure OctoPack is modifying a C# project file in an expected manner.
I also added entries to .gitignore to ignore NCrunch specific files, since I'm an NCrunch user and I was asked to ensure that these files are not committed to the repository.
I ran the tests three different ways: Visual Studio IDE (the standard test runner), NCrunch, and via the Cake script. In fact, I ran the Cake script before pushing up this commit to make this PR. In fact, I ran the Cake script before pushing up each of the 3 PRs I created! 😄
So, I wonder what's different about your environment, or how you're running the tests? Did you actually do a build first? Sorry, have to ask, because the build contains a TypeScript compiler that compiles the TypeScript files to generate those JavaScript files mentioned in the error message. However, having just written that, it occurs to me that the unit test should be automatically building that project, causing those JavaScript files to be generated, and then which ought to be included in the OctoPack package.
Hi @fourpastmidnight, shipping your other 2 PRs as 3.6.5. This PR makes me the most nervous, not entirely convinced the changes are worth it considering how risk-averse we are for OctoPack. I've run out of time to continue reviewing this PR, I'm rolling on to a build cycle. I will leave this PR in my colleagues hands to get more perspective.
@tothegills Will a NuGet package for 3.65 soon be published? It's not showing up in the releases tab, which is why I'm asking.
@tothegills Never mind—I see it is up on NuGet.org. Thanks!
I'm going to pull down this branch again and see if I encounter errors running the tests.
We have flagged this as an issue with product, but at this point we do not have capacity to assign an engineer to resolve the issue. We'll keep the issue open, but unfortunately we can not provide any guidance as to when it will be resolved.
