Nevermore icon indicating copy to clipboard operation
Nevermore copied to clipboard

Nevermore BeginReadTransaction method does not create a SQL transaction and therefore will not hold a transaction name

Open akirayamamoto opened this issue 4 years ago • 0 comments

I was writing some tests and found out that BeginReadTransaction method does not create a transaction and therefore will not hold a transaction name.

I could only find references to BeginReadTransaction on Octofront so Octopus Server is not affected.

I see these options for us:

  • Change the Nevermore behavior to actually open a transaction when calling such method. This could cause lock issues on Octofront.
  • Change the method name to something like BeginConnection instead so we are not expecting a transaction.

Tests here: https://github.com/OctopusDeploy/Nevermore/pull/162 See related PR: https://github.com/OctopusDeploy/Nevermore/issues/106

akirayamamoto avatar Sep 14 '21 01:09 akirayamamoto