Deployment target tag warning in process editor not considering all associated target tags

[patrick-smergut-octopus]

Severity

Will incorrectly warn any users with more than a few (4?) matching targets

Version

2024.4.7020

Latest Version

None

What happened?

The deployment target tag warning is displayed for any unique tags not associated with the first few targets presented in the short preview list. For example, if there are 4 deployment targets in the preview list with a tag of test-tag-one, and a 5th one not shown in the list with test-tag-two, then a warning will be shown for test-tag-two.

The warning should be suppressed for all associated tags, not just the ones associated with targets presented in the short preview list.

This doesn't seem to impact deployments, only the warning presented in the deployment process editor.

Reproduction

1. Add 5 targets (with the 5th being alphanumerically last) to an instance with the following tags:
   • Targets 1-4: Tag: Tag1, Env: Test
   • Target 5: Tag: Tag2, Env: Development
2. Create a new project with a 'Run a Script' step that deploys to targets with the tags Tag1, Tag2
3. Check the warning at the top of the deployment process to see 'Tag2' isn't associated, even though Target 5 is associated

Error and Stacktrace

More Information

Internal reproduction here.

Related to enhancement: https://github.com/OctopusDeploy/Issues/issues/9045

Workaround

No response