Issues icon indicating copy to clipboard operation
Issues copied to clipboard

Empty target roles should not match any Kubernetes cluster targets

Open ghost opened this issue 2 years ago • 1 comments

Severity

Found by internal staff, no customers are reporting this yet

Version

Existing on master, haven't tried earlier versions

Latest Version

I could reproduce the problem in the latest build

What happened?

When running a Kubernetes deployment and no target roles are given, I expect the server to detect that no matching deployment targets are found and skip the deployment. However, it actually attempts to perform the deployment which fails with an error of "Kubernetes cluster URL is missing".

Expected Screenshot 2023-10-09 at 3 56 12 PM

Actual Screenshot 2023-10-09 at 4 50 11 PM

Reproduction

  • Create a deployment process to run raw kubernetes yaml step
  • Configure the step to run on worker on behalf of each deployment target
  • Make sure the target roles are left empty
  • Create release and deploy
  • Observe that the deployment runs and the server attempts to deploy kubernetes yaml, but fails with "Kubernetes cluster URL is missing" error.

Error and Stacktrace

No response

More Information

No response

Workaround

Do not leave target roles empty.

ghost avatar Oct 09 '23 03:10 ghost