Halibut icon indicating copy to clipboard operation
Halibut copied to clipboard

DataStream.FromString does not pass the cancellation token, meaning we wont respect cancelled RPC calls.

Open LukeButters opened this issue 2 years ago • 0 comments

Since the CancellationToken is not passed, if an RPC call is cancelled the cancellation of the cancellation token wont result in the write being cancelled resulting in Halibut taking longer to cancel the call.

This can be worked around by using one of the other DataStream constructor methods.

Note that stream timeouts still apply, so Halibut can not be stuck forever in the write.

The issue is in the code below. image

LukeButters avatar Dec 18 '23 05:12 LukeButters