Calamari icon indicating copy to clipboard operation
Calamari copied to clipboard

fix Python updateprogress()

Open smlng opened this issue 2 years ago • 3 comments

According to the documentation the message for updateprogress in Python scripts is optional. However, when a message is not provided the script fails because the default for message is None which is then passed to the inner encode() function that does not like None.

In this fix the default value for message is changed from None to "" (empty string). Further this PR provided necessary test fixtures to assert the correct behavior.

smlng avatar Oct 07 '22 20:10 smlng

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 07 '22 20:10 CLAassistant

Ping, just some minor changes. Do I need to do something to move this forward.

smlng avatar Oct 26 '22 10:10 smlng

Thanks for the PR @smlng. I've created a fresh branch and PR, as our build scripts are exposed within this repository we do not automatically build community pull requests and have to trigger them manually. Some new security measures internally have prevented us from manually triggering these, and I'm waiting for confirmation whether I can. In the meantime, I've branched off of your changes and created a fresh pull request. I'll take a look at the changes early next week and see if we can get them merged in. Thanks again for the contribution!

IsaacCalligeros95 avatar Oct 28 '22 04:10 IsaacCalligeros95