Calamari icon indicating copy to clipboard operation
Calamari copied to clipboard

Wire 1password SDK into Calamari

Open rain-on opened this issue 1 year ago • 4 comments

This includes the following changes:

  • introduces Octopus.1password.sdk as a dependency of Calamari.Testing
  • Updates ExternalVariables.Get to fetch a secret from 1password if no env-var is avilable
  • Adds "secret reference to the externalVariables documented in our ticket"

NOTE: the vault in 1password is not yet updated, thus all values will be taken from an env-var, not the vault.

rain-on avatar May 06 '24 06:05 rain-on

My only concern is the Secret References are missing the field name, otherwise looks very similar to the OctopusDeploy repository from the top of my head.

akirayamamoto avatar May 06 '24 06:05 akirayamamoto

Overtaken by https://github.com/OctopusDeploy/Calamari/pull/1254, Will backport comments.

rain-on avatar May 08 '24 06:05 rain-on

overtaken by other PRs.

rain-on avatar May 10 '24 03:05 rain-on

@rain-on Can this be closed?

APErebus avatar May 22 '24 12:05 APErebus