plugins.octoprint.org icon indicating copy to clipboard operation
plugins.octoprint.org copied to clipboard

[Abandoned Plugin] SpoolManager

Open rtrout opened this issue 1 year ago • 9 comments

Which Plugin?

https://github.com/dojohnso/OctoPrint-SpoolManager

Link to ticket on plugin's issue tracker confirming abandonment

https://community.octoprint.org/t/is-spool-manager-still-in-development/60025/6

https://github.com/dojohnso/OctoPrint-SpoolManager/issues/54

Is there someone open to adopting it?

No response

rtrout avatar Sep 04 '24 20:09 rtrout

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/is-spool-manager-still-in-development/60025/7

GitIssueBot avatar Sep 04 '24 20:09 GitIssueBot

would like to get @dojohnso 's input directly rather than taking information second hand.

jneilliii avatar Sep 04 '24 22:09 jneilliii

would like to get @dojohnso 's input directly rather than taking information second hand.

Doug has now responded here: https://github.com/dojohnso/OctoPrint-SpoolManager/issues/54#issuecomment-2330254412

rtrout avatar Sep 05 '24 00:09 rtrout

I saw mdziekon/Octoprint-SpoolManager which was another fork of Olli's repository. It has quite a few commits but no recent ones. I posted an issue there asking if the maintainer is still interested in the plugin. Otherwise, I might think about taking it over. I was originally interested in FilamentManager for an integration with another plugin but saw that it has been abandoned, too, and people were using SpoolManager now.

WildRikku avatar Sep 05 '24 05:09 WildRikku

would like to get @dojohnso 's input directly rather than taking information second hand.

Yeah I don't have the time to work on it so you all can move ahead with whatever is needed to take this over. same for my PrintJobHistory plugin

dojohnso avatar Sep 05 '24 18:09 dojohnso

Alright, I can take over the SpoolManager plugin. I spent the last night figuring out some things and think I can handle the codebase and existing issues and also have some fun. :)

I created a fork, activated issues and made some notes already. https://github.com/WildRikku/OctoPrint-SpoolManager

I also forked this repository and started preparing the pull request that would seal the takeover if I understood it correctly. I use this PR as reference: https://github.com/OctoPrint/plugins.octoprint.org/pull/1255/files I am unsure about the changes made to notices.yaml and update_check_overlays.yaml. The first I think is to re-distribute the plugin without making a release? I'd write a bugfix I want to work on anyway and make a release as an exercise, so no change necessary then? And for update_check_overlays.yaml, that looks like it does the same? Or do they work together and one is for notification and one is for actually pointing to new source? Would I add my lines to the files or replace those from the previous PR?

WildRikku avatar Sep 11 '24 08:09 WildRikku

Or do they work together and one is for notification and one is for actually pointing to new source? Would I add my lines to the files or replace those from the previous PR?

This is exactly the situation, they each control different aspects of the notification and update process.

I also forked this repository and started preparing the pull request that would seal the takeover if I understood it correctly. I use this PR as reference: #1255 (files)

Yes, this is a good example. You would also want to remove the abandoned setting currently in the top of SpoolManager.md file.

jneilliii avatar Sep 12 '24 01:09 jneilliii

Thank you. I have opened #1324 accordingly (at least I hope so).

WildRikku avatar Sep 12 '24 16:09 WildRikku

Big thank you @WildRikku, 1.7.4 fixed the CSV download bug for me.

rtrout avatar Sep 15 '24 23:09 rtrout

Since the plugin has been adopted, shouldn't this issue be closed?

jacopotediosi avatar Apr 14 '25 22:04 jacopotediosi