plugins.octoprint.org icon indicating copy to clipboard operation
plugins.octoprint.org copied to clipboard

[Abandoned Plugin] TouchUI

Open roblandry opened this issue 2 years ago • 32 comments

Which Plugin?

https://plugins.octoprint.org/plugins/touchui/

Link to ticket on plugin's issue tracker confirming abandonment

https://github.com/BillyBlaze/OctoPrint-TouchUI/issues/535

Is there someone open to adopting it?

No response

roblandry avatar Dec 01 '22 23:12 roblandry

sad face. I still use this app with my prints.

wwian avatar Dec 02 '22 22:12 wwian

What’s the process to take this over? Fork and re-submit?

imjosecampos avatar Dec 04 '22 03:12 imjosecampos

Fork, address any outstanding major issues relative to compatibility, etc. bump version and submit PR to redirect the update checks. A good example can be found here of such a PR.

jneilliii avatar Dec 04 '22 06:12 jneilliii

Sounds good, will install and check the issues to see how much work may be involved and report back.

imjosecampos avatar Dec 04 '22 14:12 imjosecampos

Probably the biggest issue is an incompatibility with Octoprint 1.8.0+. See https://github.com/BillyBlaze/OctoPrint-TouchUI/issues/532 for more info.

There is a link in there to a branch I made and have been using locally that fixed that problem, but I was never entirely happy with it because it broke backwards compatibility with older Octoprint versions. Maybe that is less of a problem now, since 1.8.0 has been out for awhile now? Either way, hopefully it helps!

vexofp avatar Dec 04 '22 19:12 vexofp

I've been wondering what happened to the temp graph. 😅

Well, if the plugin transfers ownership, that would provide a convenient time to shift compatibility to 1.8.0+. Just my 2 cents.

JohnathonMohr avatar Dec 06 '22 23:12 JohnathonMohr

I use TouchUI as well. I would be up to Patreon someone to take over. It's a popular plugin

sfarkhan avatar Dec 28 '22 23:12 sfarkhan

Has there been any update on this? I use this on all of my printers, I would gladly donate to whoever took this over, its a great Plugin!! It would be a shame to loose it.

TheNore avatar Feb 16 '23 21:02 TheNore

but I was never entirely happy with it because it broke backwards compatibility with older Octoprint versions

You could do a copy of the file and conditionally load the different file based on OctoPrint version. Here's an example of where I've used this.

https://github.com/jneilliii/OctoPrint-TPLinkSmartplug/blob/27d265aadf164f2f2aebad99ef64874af029d869/octoprint_tplinksmartplug/init.py#L337

Also, it's always better to utilize id css selector if at all possible, just not sure without looking directly at it if that's available here or not.

jneilliii avatar Feb 17 '23 06:02 jneilliii

So sad... Still using on 10.1 touchscreen :(

Thierry-Myron avatar Feb 21 '23 05:02 Thierry-Myron

I'm considering taking a look at the plugin, fixing the graph, and maybe some quality-of-life updates, just asking here if someone else is already on it so that we don't duplicate our efforts

Unn4m3DD avatar Mar 01 '23 14:03 Unn4m3DD

Go for it. I was going to but work picked up and this fell off my plate

imjosecampos avatar Mar 01 '23 15:03 imjosecampos

Well, I have it sorted out. I've created a fork with the changes, can someone help me with how to make the update reach octoprints repositories? https://github.com/Unn4m3DD/OctoPrint-TouchUI image

Unn4m3DD avatar Mar 01 '23 19:03 Unn4m3DD

@Unn4m3DD , I think the legend and temperature values at the bottom there still look messed up. They should look like this: image

Please feel free to steal from https://github.com/BillyBlaze/OctoPrint-TouchUI/compare/master...vexofp:532-temp-graph-1.8.x (if helpful)!

vexofp avatar Mar 05 '23 00:03 vexofp

I thought those bars were sliders xD I managed to get to this, should be close enough image

Unn4m3DD avatar Mar 08 '23 19:03 Unn4m3DD

Heyy, I have had the PR opened for some time and I'm wondering if I did it in the correct way. @vexofp, you seem to know your way around the octoprint community, any chance you might be able to help me understand this?

Unn4m3DD avatar Mar 17 '23 13:03 Unn4m3DD

If you want to adopt the plugin it's just a matter of submitting a PR here that configures the correct update check overlays, the plugin listing data adding you as an author and a bumped version with release on your fork of the plugin. Here is an example of a completed adoption PR to see what I mean.

https://github.com/OctoPrint/plugins.octoprint.org/pull/1157/files

jneilliii avatar Mar 18 '23 14:03 jneilliii

I'll take this over. Ill try my best to keep it running for now

ThatMattCraig avatar Apr 03 '23 20:04 ThatMattCraig

My friend and i would love to transform this project and fix it. We will work our hardest on keeping it up. We just need someone to convert everything to python! I am new to get hub, and need to know how to take over the project.

pzwe2020 avatar May 11 '23 15:05 pzwe2020

*Github

pzwe2020 avatar May 12 '23 15:05 pzwe2020

can't get a cam stream either !!

Mbayazeed avatar Jun 16 '23 15:06 Mbayazeed

Good morning, unfortunately I don't have time to resume this plugin, however I made a fix for the webcam on my fork if you want: https://github.com/devildant/OctoPrint-TouchUI

just download the master branch as zip, and install manually inside octoprint

devildant avatar Jun 22 '23 19:06 devildant

Note: I applied the fix from @Unn4m3DD + fix temp graph settings + fix the SD card symbol in the files section

devildant avatar Jun 23 '23 00:06 devildant

image

image

image

devildant avatar Jun 23 '23 00:06 devildant

That worked perfectly.

Thanks

Kindest regards .

Sent from BlueMailhttps://bluemail.me On Jun 22, 2023, at 9:16 PM, devildant @.@.>> wrote:

Good morning, unfortunately I don't have time to resume this plugin, however I made a fix for the webcam on my fork if you want: https://github.com/devildant/OctoPrint-TouchUI

just download the master branch as zip, and install manually inside octoprint

— Reply to this email directly, view it on GitHubhttps://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1603190065, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUXU4NMK6UKY4PYHTSVVYVLXMSKZHANCNFSM6AAAAAASRKUQ4I. You are receiving this because you commented.Message ID: @.***>

Mbayazeed avatar Jun 25 '23 10:06 Mbayazeed

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

chuwy5 avatar Aug 05 '23 19:08 chuwy5

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

at the moment there is no one to take over, i just made patches on my branch to fix the problems on the latest version of octoprint. if you want to resume the project, go go :), it will please a lot of people

devildant avatar Aug 05 '23 19:08 devildant

I have been working on trying to figure out the code and I just can get it. Hopefully we can find someone else. Sorry

On August 5, 2023, at 12:33 PM, chuwy5 @.***> wrote:

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "url": "https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

pzwe2020 avatar Aug 05 '23 21:08 pzwe2020

no worries. my thought is to find a group of people that can work on it. unless i can figure it out and start maintaining it. but im down to work on it with others

On Sat, Aug 5, 2023 at 2:12 PM pzwe2020 @.***> wrote:

I have been working on trying to figure out the code and I just can get it. Hopefully we can find someone else. Sorry

On August 5, 2023, at 12:33 PM, chuwy5 @.***> wrote:

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "url": " https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

— Reply to this email directly, view it on GitHub https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666608079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISY7S2BIO6GKI4PVDW5S23XT2ZL7ANCNFSM6AAAAAASRKUQ4I . You are receiving this because you commented.Message ID: @.***>

chuwy5 avatar Aug 06 '23 04:08 chuwy5

Jesus fucking christ, the plugin STILL works fine, and I'm tired of the UI nagging me to remove it because it's "abandoned" by it's creator. (Thanks for that, douche.) How do I get it to stop nagging my system, even-though I always hit "Mark as read."? The nag is annoying as fuck to deal with, but the plugin is too useful to get rid of.

JayroJones avatar Sep 02 '23 12:09 JayroJones