OctoPrint icon indicating copy to clipboard operation
OctoPrint copied to clipboard

[Request] Remove `scripts` from repo

Open foosel opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe.

There's a bunch of init scripts for sysv and systemd located in the source tree under scripts. That stuff hasn't really been maintained over the years, and while the systemd sample is still totally fine, just like the outdated sysv one it still relies on an installation into a venv in a user's home when best practice would actually be to create a dedicated user and application folder somewhere under /opt or similar.

Describe the solution you'd like

Get rid of this stuff and have deployment information rather live in the docs or if needed in a dedicated repo.

Does anyone see any issue with that? Am I overlooking problems for any of the third party installer scripts that might be utilizing these files (@paukstelis maybe)?

Describe alternatives you've considered

No response

Additional context

No response

foosel avatar Aug 29 '23 09:08 foosel

The install guides on the forums have the user wget these files to use them in their install - that could change, but wanted to point out that as a reference.

cp2004 avatar Aug 29 '23 10:08 cp2004

No impact on octoprint_deploy.

paukstelis avatar Aug 29 '23 12:08 paukstelis

Adjusted the install guide and got rid of the files. Will be gone in 1.10.0.

foosel avatar Nov 20 '23 15:11 foosel