OctoPrint-FirmwareUpdater icon indicating copy to clipboard operation
OctoPrint-FirmwareUpdater copied to clipboard

LONG_FILENAME_WRITE_SUPPORT support

Open gryzlov opened this issue 2 years ago • 8 comments

Please, add LONG_FILENAME_WRITE_SUPPORT for FB Reborn updating

gryzlov avatar Jun 11 '22 09:06 gryzlov

Not 100% sure what you need me to do - just allow long file names in the custom file name option? I don't know if the underlying MarlinBFT protocol will accept them, and that is outside of my control.

benlye avatar Jun 13 '22 11:06 benlye

Yes, can you change regexp to support long file names?

gryzlov avatar Jun 13 '22 15:06 gryzlov

Yes, I can do that. In the meantime, if you set the custom filename option to anything other than firmware.bin the setting will be added to OctoPrint's YAML configuration file, where you can then manually change it to anything you like. You just won't be able to edit it in the UI anymore.

benlye avatar Jun 14 '22 06:06 benlye

Already tried, but get "The target filename is invalid. Filename must be 8dot3 format." error message

gryzlov avatar Jun 14 '22 07:06 gryzlov

I removed the code

if (self.getProfileSetting("flash_method") == "marlinbft" && self.getProfileSetting("marlinbft_use_custom_filename") && !self.checkMarlinBftCustomFileName()) {
                 alert = gettext("The target filename is invalid. Filename must be 8dot3 format.");
             }

and i can confirm that long names (in my case - Robin_nano35.bin) are supported and the firmware is successfully updated.

gryzlov avatar Jun 16 '22 06:06 gryzlov

Glad you figured it out, but lets keep this open until I've had a chance to add this option.

benlye avatar Jun 16 '22 08:06 benlye

how do i go about updating my ender 6, bother the firmware and the cr touch firmware? not sure if im suppose to use a flash method or not and, just flash the file to the serial port?

O1Wcreations avatar Jul 25 '22 23:07 O1Wcreations

how do i go about updating my ender 6, bother the firmware and the cr touch firmware? not sure if im suppose to use a flash method or not and, just flash the file to the serial port?

I haven't got a clue - I don't have the board. Your best bet is to find a user group for your printer and ask there.

benlye avatar Jul 26 '22 07:07 benlye

Will be addressed in 1.14.0 (available in the devel branch for testing now).

benlye avatar Nov 10 '22 20:11 benlye

Should probably update the UI side of things so it doesn't appear as error when specifying long filename and Cap:LFN_WRITE:1 in capabilities report. I just tested the latest beta version and the process worked flawlessly for me now. Thanks so much for integrating this change.

jneilliii avatar Feb 02 '23 06:02 jneilliii

This issue has been automatically locked because there was no further activity after it was closed. Please open a new issue for any related problems.

github-actions[bot] avatar Apr 10 '23 13:04 github-actions[bot]