olivine icon indicating copy to clipboard operation
olivine copied to clipboard

Some feedback

Open Kakadu opened this issue 3 years ago • 1 comments

In general, I'm curious, does this project have enough TODO's (the root file is 5 years old) to introduce a student to OCaml.

I tried to compile this, triangle renders fine with change of environment variable. Tesseract demo crashes on memory map. Don't know why. https://gist.github.com/Kakadu/d78c04938cbf40a3b179d87fd2583114

diff --git a/Makefile b/Makefile
index e969634..9c0664b 100644
--- a/Makefile
+++ b/Makefile
@@ -38,10 +38,10 @@ shaders/%/vert.spv : shaders/%/base.vert
 
 
 test-triangle: bin/triangle
-       VK_INSTANCE_LAYERS=VK_LAYER_LUNARG_standard_validation ./bin/triangle
+       VK_INSTANCE_LAYERS=VK_LAYER_KHRONOS_validation ./bin/triangle
 
 test-tesseract: bin/tesseract
-       VK_INSTANCE_LAYERS=VK_LAYER_LUNARG_standard_validation ./bin/tesseract
+       VK_INSTANCE_LAYERS=VK_LAYER_KHRONOS_validation ./bin/tesseract
 .PHONY: vkspec
 vkspec:
        mkdir -p spec \

Kakadu avatar Jan 02 '23 13:01 Kakadu

Thanks for the feedback !

Except if the student is really interested in Vulkan, I don't think that this hobby project of mine is a good fit foran introduction to OCaml: this is a code generation project from a mostly informal specification. However, the TODO is mostly still accurate, except for the handling of structure extension.

The tesseract example currently relies on the GPU memory architecture of the laptop that I was used for developing the code. I intend to fix it at some point. (I also faintly remember that there might be some issues with NVIDIA using non-registered error code.)

Octachron avatar Jan 02 '23 13:01 Octachron