Florian Angeletti comments

Results 397 comments of


                                            Florian Angeletti

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

Note that I am planning to review this PR, but I will not have time before mid-September.

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

There is already a simple solution for grouping together the printer and the printed argument: the `%t` specifier, for instance ```ocaml let () pp x ppf = pp ppf x...

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

I have some comments left on the documentation and tests, but the implementation looks fine to me.

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

Thanks for the update to the documentation ! I hope that I will have the time for a last round of review this week, but overall everything looks fine to...

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

Another option would be to export a type abbreviation ```ocaml type 'a args = 'a Arg_list.t ``` which would be enough to use `Format.args` for disambiguation purpose without breaking the...

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

`Format.Args.t` is also a good and concise name, and it would be one less type name in the name space.

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

As far as I can see, this is missing only a Change entry before we can merge.

New `Format` and `Printf` `printf`-like functions that accept a heterogeneous list as arguments

Merged with an additional Changes entry in 8d697505a4d8 . @zazedd , thanks again for the work and don't hesitate to tell if you want to update the Changes entry that...

Primitive aliases (RFC #44)

Thanks for the request ! This PR does sound like a good fit for committee consideration, I would keep you updated once the committee has chosen a shepherd.

Primitive aliases (RFC #44)

@yallop has accepted to shepherd the pull request, in other words, to summarize it to the language committee and propose a recommendation for the committee to debate.