Florian Angeletti comments

Results 397 comments of


                                            Florian Angeletti

stdlib: add an experimental alert to the Effect and Domain modules

Cherry-picked on 5.0 as dc2c2bd0877f .

An generator for `bundle_refs` files

I have at least added a description of the process that I followed for updating the reference to 5.0 in `tests/bundle_sync.ml` .

Make codept as a library (2/n)

Applying more consistently `ocp-indent` could be a sensible cleanup. I am overall not really convinced by `ocamlformat`, at least for small projects.

Make codept as a library (4/n)

Throwing a `Abort` exception and installing an exception handler in an executable sounds healthier indeed.

Use `cuts` instead of `split_on_char`

I am surprised that `astring` is using the `O( match_len * text_length)` algorithm. Do you know why?

Use `cuts` instead of `split_on_char`

I have pushed a commit 36bbd99fc88b which switch to the more complex version if the path separator is a full string (with room for optimisation if it is ever needed)....

Modest support for Unicode letters in identifiers, take 2

@Julow confirmed to me offline that he was happy with the current state of the PR. What his your opinion @gasche as the green-tick guardian for this PR?

Safe-to-marshall annotation

@gasche , do you still think we should revisit the issue now that we have revamped the handling of immediate?

Configuration file "$HOME/.config/kreadconfig5rc" not writable.

This is most probably the sandboxing. The current opam file is not really usable: the aim was to have an olivine-vulkan package generated from the olivine library.

example won't die

Ah, yes the current code only exits with esc: https://github.com/Octachron/olivine/blob/master/examples/triangle.ml#L75 that should be fixed indeed.