Florian Angeletti
Florian Angeletti
Even if this does not occur in practice, it sounds better to avoid chaining filename derivation when possible.
@gasche, in this context, the compiler is looking for the cmi of the implementation file at hand, and it only looks at the expected filename derived from the cmo. In...
The diffing algorithm is heuristic by nature. To keep the algorithm efficient we must cut branches early rather than storing all possible possible paths. Having a finer grained measure of...
Indeed, after discussion with @lthls , it sounded better to re-review the PR after this change since it makes the PR substantially simpler while covering more case of first-class module...
I squashed and merged all commit together, since in this case there was conceptually a single change with one back-and-forth iteration.
The special printing for list in the toplevel is triggered by recognizing the exact type path for list, which is very brittle and breaks when re-exporting the list type: ```ocaml...
This specific issue is indeed fixed by your PR, thanks for reminding this to me !
Currently a significant number of error message printer start by opening their own box, for instance ``` | Label_missing labels -> let print_label ppf lbl = Style.inline_code ppf (Ident.name lbl)...
This is not a bug fix but merely a second round of optimization, isn't it? If I am not mistaken, the changelog entry belongs to the "Working version" section.
I am closing this issue since the corresponding PR has been merged.