Florian Angeletti comments

Results 397 comments of


                                            Florian Angeletti

Add manual build dependency packages

Mentioning those dependencies are a good idea. However, I should probably point out that the generation of the API documentation doesn't require `hevea`: only `ocamldoc` or `odoc` are required.

Attempt at a thread-safe implementation of DLS

@gasche , there is now a maintainer approval.

Attempt at a thread-safe implementation of DLS

Sorry for the implicitness, I was pointing to the fact that @OlivierNicole's approval is now a maintainer's approval.

ocamldep documentation: fix example makefile and provide more context

What is the error that you get when trying to build the manual?

ocamldep documentation: fix example makefile and provide more context

I meant the error that you get when building the compiler : > Note: I wasn't able to check that the TEX still compiles and renders correctly because make in...

Invalid_argument("List.iter2") for ill-aritied types in recursive modules.

As far as I can see, the error has been introduced in OCaml 3.11.0 and it is still present in trunk.

Invalid_argument("List.iter2") for ill-aritied types in recursive modules.

Fixed in #13055 by adding a consistency check step before checking for recursive module inclusion.

Restore the MSVC port of OCaml

Updating the Windows Jenkins worker sounds fine to me.

doc: add when some functions are introduced (`@since`)

Thanks for the PR ! It is indeed problematic that `ocamldoc` does not render the `@since` tag on this section. However, `odoc` does. Thus I am not sure if duplicating...

Use webman/*.html and webman/api for OCaml.org manuals

I am not sure how this change would impact `ocaml.org` ? It is not like the files built in `webman/manual` or `webman` are published directly. Moreover, I have the impression...