ProxyManager icon indicating copy to clipboard operation
ProxyManager copied to clipboard

Published 20 hours ago • verified publisher icon Ocramius

Get ready for PHP 8.1

Open nicolas-grekas opened this issue 2 years ago • 4 comments

These test cases are needed to keep covering the related situations, but the deprecations thrown since PHP 8.1 should be silenced.

https://wiki.php.net/rfc/phase_out_serializable

nicolas-grekas avatar Mar 01 '22 14:03 nicolas-grekas

I updated with PR with 3 commits:

  • Update composer files for PHP 8.1
  • Expect deprecations about Serializable
  • Generate tentative types when appropriate

Together, the make tests green on PHP 8.1.

nicolas-grekas avatar Mar 02 '22 09:03 nicolas-grekas

Please speed up the update to 8.1, it's very necessary! 🙏

makaronnik avatar Apr 24 '22 23:04 makaronnik

I haven't worked on this yet: not on my priority list at the moment, as much more other stuff is in the way.

Ocramius avatar Apr 24 '22 23:04 Ocramius

Would it be possible to at least lift the requirement for php ~8.0.0 in composer.json. As I understand there is no actual risk for using the library with php 8.1.

etremblay avatar Jun 08 '22 19:06 etremblay

@Ocramius any progress made? really need it for a 8.1 project

jvanschie avatar Oct 31 '22 11:10 jvanschie

Nope: working on this component gives me massive anxiety (not sure if that is the exact naming - haven't gotten a professional to diagnose it) these days, so I'm probably holding off until I feel better about it.

Ocramius avatar Oct 31 '22 11:10 Ocramius

Nope: working on this component gives me massive anxiety (not sure if that is the exact naming - haven't gotten a professional to diagnose it) these days, so I'm probably holding off until I feel better about it.

Hello @Ocramius,

Don't want to stress and/or pressure but maybe there are any updates for this PR?

bc-anton-k avatar Mar 02 '23 11:03 bc-anton-k

hey @Ocramius, is there a way forward with this? Is there something we can help with to get this to a state you're happy with? PHP 8.0 is now out of active support and many people are looking at upgrading before EOL later this year, so getting some resolution would be really appreciated. Thanks in advance!

TomA-R avatar Mar 15 '23 07:03 TomA-R

For anyone watching this issue, we've swapped this library for https://github.com/FriendsOfPHP/proxy-manager-lts. Considering PHP 8.0 no longer has active support and will discontinue security support in 5 months, it seems like this library should no longer be used.

TomA-R avatar May 29 '23 07:05 TomA-R

FWIW, I stopped most maintenance activities except security maintenance here precisely because of the LTS fork butting in: this library is now a source of huge anxiety and frustration for me.

I may pick it up again if my brain decides that it isn't a source of sadness (or my therapist finds some magic), instead of pride and joy as it used to be, but I fully understand that people just want to get stuff done.

It's almost an exemplary case of MIT licensing being a terrible choice: should've been AGPL+Commercial from the start, but I was young and foolish.

Ocramius avatar May 29 '23 07:05 Ocramius