OceanicNomad

Combat Report Generation Error

4

These changed will produce a correct combat report instead of a server error. https://github.com/XGProyect/XG-Proyect-v3.x.x/blob/d1d9dc7ed498c4417f41b955871d4b67e0bb39d7/app/Libraries/BattleEngine/Core/BattleReport.php#L259 `_DEBRIS_FACTOR` needs to be changed to `SHIPS_DEBRIS_FACTOR` https://github.com/XGProyect/XG-Proyect-v3.x.x/blob/d1d9dc7ed498c4417f41b955871d4b67e0bb39d7/app/Libraries/BattleEngine/Core/BattleReport.php#L281 `_DEBRIS_FACTOR` needs to be changed to `DEFENCE_DEBRIS_FACTOR`

Combat not working PHP 8 fix

1

Instead of dynamically creating the `fighters` property as in previous versions of PHP, we need to explicitly declare it at the beginning of the class. https://github.com/XGProyect/XG-Proyect-v3.x.x/blob/d1d9dc7ed498c4417f41b955871d4b67e0bb39d7/app/Libraries/BattleEngine/CombatObject/PhysicShot.php#L62 Add `private $fighters;` below...

Fixed bugs and added API

4

I fixed the bugs with the combat system, one issue was PHP 8 related and the other an incorrectly defined constant in report generation. Also implemented an API feature ...

Error installing using WAMP on Windows

2

When trying to install on Windows using WAMP or similar, the following needs to be removed. https://github.com/XGProyect/XG-Proyect-v3.x.x/blob/d1d9dc7ed498c4417f41b955871d4b67e0bb39d7/app/Http/Controllers/Install/InstallationController.php#L440-L442 https://github.com/XGProyect/XG-Proyect-v3.x.x/blob/d1d9dc7ed498c4417f41b955871d4b67e0bb39d7/app/Http/Controllers/Install/InstallationController.php#L456-L458