parcels icon indicating copy to clipboard operation
parcels copied to clipboard

Refactoring of CField struct to include gridindexingtype and interp_method

Open erikvansebille opened this issue 1 year ago • 1 comments

Following #1612, where we need to provide the gridindexingtype on the CField struct for technical reasons, it makes sense to also use it throughout the rest of the C-code. Hence, this PR refactors the code to not require the gridindexingtype and interp_method when calling a Field evaluation in C, but get them from the CField itself

erikvansebille avatar Aug 29 '24 07:08 erikvansebille

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Additional details and impacted files
@@                     Coverage Diff                     @@
##           analyticaladvection_in_jit    #1673   +/-   ##
===========================================================
  Coverage                       86.22%   86.22%           
===========================================================
  Files                              67       67           
  Lines                           11827    11828    +1     
===========================================================
+ Hits                            10198    10199    +1     
  Misses                           1629     1629           
Flag Coverage Δ
integration-tests 64.85% <100.00%> (+<0.01%) :arrow_up:
unit-tests 80.62% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
parcels/field.py 89.72% <100.00%> (+<0.01%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 29 '24 07:08 codecov[bot]

Will be solved in v4

erikvansebille avatar Feb 10 '25 15:02 erikvansebille