Obsidian_to_Anki icon indicating copy to clipboard operation
Obsidian_to_Anki copied to clipboard

Bugfix/519 extra line break added to file link

Open mattcoleanderson opened this issue 1 year ago • 7 comments

closes #519

@ShootingKing-AM I've tested the change manually, however I ran into issues running the python test scripts. So I wouldn't be surprised if the e2e test fails initially.

mattcoleanderson avatar Feb 12 '24 22:02 mattcoleanderson

Before

image

After:

image

mattcoleanderson avatar Feb 12 '24 22:02 mattcoleanderson

Thanks for the PR. Can this be made as an setting, which is default Off. Since many people would be used to the line break by now.

ShootingKing-AM avatar Feb 13 '24 09:02 ShootingKing-AM

Thanks for the PR. Can this be made as an setting, which is default Off. Since many people would be used to the line break by now.

I can work on that.

mattcoleanderson avatar Feb 13 '24 17:02 mattcoleanderson

Thanks for the PR. Can this be made as an setting, which is default Off. Since many people would be used to the line break by now.

@ShootingKing-AM I've added a toggle to the settings for prepending the line break.

I've also added some code to main.js that when loading settings, will merge the default settings with settings saved to data.json. I noticed that prior behavior lead to newly added default settings not being added to the settings menu unless deleted your data.json. Now that's fixed.

mattcoleanderson avatar Feb 14 '24 00:02 mattcoleanderson

@ShootingKing-AM Any chance of merging this PR?

mattcoleanderson avatar Apr 02 '24 05:04 mattcoleanderson

@mattcoleanderson this is blocked by https://github.com/ObsidianToAnki/Obsidian_to_Anki/issues/447 :(

ShootingKing-AM avatar Apr 11 '24 09:04 ShootingKing-AM

Thanks for fixing this, @mattcoleanderson. If it's not too much to ask, could you tell me how I'd overwrite the current plugin files (installed inside Obsidian) with the changes you've made?

samawelch avatar Apr 23 '24 12:04 samawelch